search

Astrocoders / lenses-ppx

GADT lenses
MIT License
105 stars 10 forks source link

remove ppx-flags entry that was breaking install & build #8

Closed elnygren closed 5 years ago

elnygren commented 5 years ago

7

looks like removing this line is fine and doesn't break anything yarn install etc. work again in my project that is using lenses-ppx

fakenickels commented 5 years ago

hey thanks for this! Though the ppx-flags in the repo is for development when testing, which version of BS are you using?

elnygren commented 5 years ago

@grsabreu I have "bs-platform": "^5.0.0", in my projects!

tbh I don't know much about bsconfig or developing ppx syntax extensions, just reporting behavior I noticed about installing this package.

(I'm using this with Reforms next, nice work btw guys!)

fakenickels commented 5 years ago

got it @elnygren ! I think we can go ahead and merge this for now, as we actually intended to rewrite this with esy (#9).

I'm glad you are finding ReForm next useful!!! let us know any suggestions there