Closed surbhi400 closed 1 year ago
@surbhi400 I am here to help you. Please feel free to ask any questions, and I will gladly address them.
Ok i am on it.
@surbhi400, please feel free to get in touch if there are any issues or if you need any assistance. I was just checking in because it has been 2 weeks.
@surbhi400, please feel free to get in touch if there are any issues or if you need any assistance. I was just checking in because it has been 2 weeks.
Hey @Anmol-Baranwal, I am really sorry actually I had my internal exams going on and then I broke my laptop screen that is why this took this much time. I sincerely apologize for causing you inconvenience. I will get this done by Monday.
No worries, feel free to complete it whenever you get time. No need to rush.
@surbhi400 Any update?
@Anmol-Baranwal could you tell me what could be the problem that it is showing this error. I have already done git pull and it shows its up to date.
@Anmol-Baranwal could you tell me what could be the problem that it is showing this error. I have already done git pull and it shows its up to date.
It seems like you are facing an error while trying to push changes to a remote branch on GitHub. The error message is suggesting that the remote branch you are trying to push to has some changes that are not present in your local branch.
To resolve this issue, you need to first integrate the remote changes into your local branch by running the following command:
git pull origin emailvalidator
This command will fetch the changes from the remote branch to your local branch and merge them.
After resolving any conflicts that may arise during the merge, you can try pushing the changes again using the command:
git push origin emailvalidator
This should push your changes to the remote branch successfully.
Do let me know if this doesn't works.
@Anmol-Baranwal It worked. I worked on the changes 1 and 3 you asked me to like now it provides the issue with the email. But I am not very sure of the 2nd change you asked for. Like it still statisfies the one example you mentioned . Can you please guide me that how should I fix that part.
@Anmol-Baranwal It worked. I worked on the changes 1 and 3 you asked me to like now it provides the issue with the email. But I am not very sure of the 2nd change you asked for. Like it still statisfies the one example you mentioned . Can you please guide me that how should I fix that part.
I will review the changes. If the example works, then these will be enough for me to merge the PR.
@Anmol-Baranwal It worked. I worked on the changes 1 and 3 you asked me to like now it provides the issue with the email. But I am not very sure of the 2nd change you asked for. Like it still statisfies the one example you mentioned . Can you please guide me that how should I fix that part.
I will review the changes. If the example works, then these will be enough for me to merge the PR.
No sorry, my mistake. I meant to say it does not satisfy the one example you mentioned. And that is why I want you guide me about how to fix it.
You can merge it @Anmol-Baranwal You have covered all the points and changes above. Looks good to me for basic functionality of the validator.
Thank you @surbhi400 for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)
🛠️ Fixes Issue (Number)
Closes #issue_number
930
👨💻 Changes proposed
✅ Check List (Check all the applicable boxes)
📷 Screenshots