added dark mode for analog clock

Astrodevil / ZeroOctave-Javascript-Projects

This Repository Contains 150+ web development Projects.

https://zerooctave.github.io/ZeroOctave-Javascript-Projects/

MIT License

536 stars 454 forks source link

added dark mode for analog clock #1048

Closed aysal04 closed 1 year ago

aysal04 commented 1 year ago

🛠️ Fixes #976

Closes #976

👨‍💻 Changes proposed

I have added a toggle checkbox that allows us to switch between light and darkmodes. For this I have used basic java script to change the colors based on the status of the checkbox.

✅ Check List (Check all the applicable boxes)

[x] You have linked this PR to the correct issue.
[x] My code doesn't break any part of the project (Zero Octave-Javascript-Projects).
[x] This PR does not contain plagiarized content.
[x] My Addition/Changes works properly and matches the overall repo pattern.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

As the color of the numbers on the clock is fixed, we couldn't change them. However grey suits both the themes. Here is the preview of light and dark mode UI/UX designs of Analog clock.

Analog Clock UI Light Analog Clock UI Dark

📷 Screenshots

aysal04 commented 1 year ago

Yeah sorry. I deleted it accidentally. Currently I have made some changes to address issue #928 . Can I commit both the changes together here? Or shall a open a new PR?

Anmol-Baranwal commented 1 year ago

Yeah sorry. I deleted it accidentally. Currently I have made some changes to address issue #928 . Can I commit both the changes together here? Or shall a open a new PR?

It is always recommended to work on different issues using separate branches in order to maintain a clean history.

Additionally, since the issue in question has not been assigned to you, you can proceed with working on it if the assigned person does not submit a pull request (PR) in a timely manner.

Just commit the changes for this pull request here and refrain from addressing any other issues in this pull request.

github-actions[bot] commented 1 year ago

Thank you @aysal04 for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)

aysal04 commented 1 year ago

Thank you @aysal04 for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)

It was an amazing experience contributing for the first time to an open source. Thanks to my mentor for such an amazing guidance

aysal04 commented 1 year ago

Appreciate your contribution :)

It was really an amazing experience contributing for the first time to an open source. Thanks to you for being so supportive