Astrodevil / ZeroOctave-Javascript-Projects

This Repository Contains 150+ web development Projects.
https://zerooctave.github.io/ZeroOctave-Javascript-Projects/
MIT License
536 stars 454 forks source link

Longest Word #1050

Closed aswinisamantray closed 1 year ago

aswinisamantray commented 1 year ago

👨‍💻 Changes proposed I have used basic JavaScript to add a new feature i.e. to display the longest word in text and the length of the longest word. Above changes are made in the Live Word Counter project.

✅ Check List (Check all the applicable boxes)

📷 Screenshots

PR

Anmol-Baranwal commented 1 year ago

I will review this till tomorrow evening.

aswinisamantray commented 1 year ago

You may merge the PR now. I will work on improving the styling later.

On Fri, Jun 16, 2023, 2:29 PM Anmol Baranwal @.***> wrote:

@.**** approved this pull request.

Works as mentioned :)

@aswinisamantray https://github.com/aswinisamantray

Will you improve the styling, or do you suggest merging the pull request with this basic set of styling?

I will merge the PR, just please let me know.

— Reply to this email directly, view it on GitHub https://github.com/ZeroOctave/ZeroOctave-Javascript-Projects/pull/1050#pullrequestreview-1483041186, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV45CG6WVVI6E2XDQHIPSOLXLQN7RANCNFSM6AAAAAAX436FRI . You are receiving this because you were mentioned.Message ID: <ZeroOctave/ZeroOctave-Javascript-Projects/pull/1050/review/1483041186@ github.com>

Anmol-Baranwal commented 1 year ago

You may merge the PR now. I will work on improving the styling later.

Since this is responsive enough, I will go ahead and merge the PR, although you are supposed to work on the styling before merging it.

aswinisamantray commented 1 year ago

You may merge the PR now. I will work on improving the styling later.

Since this is responsive enough, I will go ahead and merge the PR, although you are supposed to work on the styling before merging it.

Have you not integrated the changes in the project yet? I can't see them that's why I asked.

github-actions[bot] commented 1 year ago

Thank you @aswinisamantray for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)