Astrodevil / ZeroOctave-Javascript-Projects

This Repository Contains 150+ web development Projects.
https://zerooctave.github.io/ZeroOctave-Javascript-Projects/
MIT License
536 stars 454 forks source link

Closes #968 url-shortner-added #1068

Closed ShreeveshKumar closed 1 year ago

ShreeveshKumar commented 1 year ago

🛠️ Fixes Issue (#968 )

Closes #issue_number

#968

👨‍💻 Changes proposed

Added the url-shortner website its html,css,js and images

✅ Check List (Check all the applicable boxes)

📄 Note to reviewers

you will need to put your own API_KEY

968 need to be merged

📷 Screenshots

image

Anmol-Baranwal commented 1 year ago

Please add a video of its working, I won't be able to review the code properly. If it works, then I will merge it.

ShreeveshKumar commented 1 year ago

Please add a video of its working, I won't be able to review the code properly. If it works, then I will merge it.

sure here it is ...

https://github.com/ZeroOctave/ZeroOctave-Javascript-Projects/assets/115733778/fc62dd65-a118-4336-b7ea-d1299e12216e

ShreeveshKumar commented 1 year ago

No abt the API key and the limit is 1000/month

Anmol-Baranwal commented 1 year ago

I don't think, this will properly work once hosted on the deployed link.

So, I will not be able to merge this. This is clearly specified in the contributing guidelines as well.

ShreeveshKumar commented 1 year ago

ok no worries

Anmol-Baranwal commented 1 year ago

ok no worries

Thanks for understanding.

If you want to contribute, you can visit Linkshub. I'm the maintainer there. Just comment on issue with tag up for grabs and I will assign you one.

ShreeveshKumar commented 1 year ago

oh thank you so much ! I would love to contribute to amazing open-source projects and join the open-source community : )

Anmol-Baranwal commented 1 year ago

Closing due to above mentioned reason.

github-actions[bot] commented 1 year ago

Thank you @ShreeveshKumar for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)