Astropilot / ValheimTooler

A fancy cheats tool for the Valheim game
MIT License
52 stars 12 forks source link

ValheimTooler as BepInEx Mod? #5

Closed KillerGoldFisch closed 3 years ago

KillerGoldFisch commented 3 years ago

Hi @Astropilot,

first of all: Thanks for this awesome tool!

I was wondering why this isn't a Mod?

I tried loading the unmodified "ValheimTooler.dll" assembly using a BepInEx mod and it worked like a charm. No need to inject the dll. This would make it much more accessable and does not scare people away by requering them to give elevated privileges to a software the may not trust.

Here is my loader mod: https://github.com/KillerGoldFisch/ValheimToolerLoaderMod

Cheers!

Astropilot commented 3 years ago

Hi @KillerGoldFisch !

First of all, thank you for your consideration of this project 😄

The main reason is simply that the community targeted by this tool is more the cheaters than the mods users. I'm not a mod user myself and although I've heard about BepInEx I was never interested in it.

On cheats forums, it's not uncommon to have to run programs with high privileges, and that's why I never asked myself about trusting my tool ^^

I did some research on BepInEx and its integration with Valheim as well as your code to package my DLL in a plugin and I see a lot of advantages:

I'm still willing to keep the current system, for those who don't want to install BepInEx just for this tool, but I'm not opposed to providing a version as a BepInEx plugin as well. From what I've seen of your code, it looks relatively simple to package and since I don't need to port all the code into the plugin, the additional development burden is very low.

If you agree, I will add a new project to my solution based on your code to allow the generation of the BepInEx plugin, and then I will post it on thunderstore and nexusmods.

Thanks again for your proposal! 👍

Yours truly, Astropilot

KillerGoldFisch commented 3 years ago

Yes, i completely agree. Since it did work without any modification of "ValheimTooler.dll", it would be a waste of opportunity not supporting both.

Distributing it additionally on the thunderstore and nexusmods would also give the well deserved recognition.

Feel free to use my code as you whish, thats why i made the repo! 😄

Since you are not into modding, they commonly get dirtibuted in a zip file with this structure:

Zip file/
├─ BepInEx/
│  ├─ plugins/
│  │  ├─ ValheimTooler/
│  │  │  ├─ ValheimToolerLoaderMod.dll
│  │  │  ├─ ValheimTooler.dll
│  │  │  ├─ INIFileParser.dll
├─ readme.txt
├─ licence.txt

Thanks for accepting my request!

Cheers!

Astropilot commented 3 years ago

Great news, the modded version of the tool is now available :) Thanks to your code I could go relatively fast!

The mod is available on the following links:

The new project is present under the name ValheimToolerMod in the repository and I updated the credits to include you (well deserved!)

Thanks again and don't hesitate if you have other remarks.

Best regards, Astropilot