Publishing to config directory for Laravel 11

Astrotomic / laravel-translatable

A Laravel package for multilingual models

https://docs.astrotomic.info/laravel-translatable/

MIT License

1.22k stars 152 forks source link

Publishing to config directory for Laravel 11 #411

Closed Milosfamous closed 1 week ago

Milosfamous commented 3 weeks ago

Issue description

This command doesn't work for Laravel version 11 • php artisan vendor:publish ‐‐tag=translatable

How to solve this issue?

You should change above command to: • php artisan vendor:publish --provider "Astrotomic\Translatable\TranslatableServiceProvider"

Oleksandr-Moik commented 3 weeks ago

Hi!

Where did you get this and what OS did you try it on?

It looks like your command has a broken dash symbol. Your dash: ‐‐ - (ord('‐') = 226) Dash copied from docs -- (ord('-') = 45)

Publishing by tag still works well php artisan vendor:publish --tag=translatable

Milosfamous commented 3 weeks ago

Hi, In your package page on GitHub a found this link: How to Add Multi-Language Models to Laravel QuickAdminPanel In step 4 you can find how to publish config.php but in your package this artisan command not mentioned. My Laravel 11 app runs on a VPS with Ubuntu 22.04 OS.

Oleksandr-Moik commented 3 weeks ago

Ok, I got it. Thank you.

Looks like just a typo in the article :)

Both publishing options are still valid - by tag and by provider. It does not need to be changed.

Even browser can find regular dash in this command ))

Milosfamous commented 3 weeks ago

Thank you very much for your attention 🙏.

Gummibeer commented 1 week ago

Thanks for solving that one @Oleksandr-Moik ! 🙏