Astroua / CARTAvis

Deprecated Repository for CARTA project. Refer to:
https://github.com/cartavis/carta
GNU General Public License v2.0
2 stars 7 forks source link

Customizable NaN Color #103

Closed low-sky closed 8 years ago

low-sky commented 9 years ago

Users have commented that they would like the NaN color to not be bright red. I propose that the default NaN color be the bottom of whatever color table is in use at the time. Users should have a tab option on Colormap settings below Color Map and Transform labeled NaN Color with a color picker and a checkbox that just says Bottom of Color Table

jeffctaylor commented 9 years ago

@pfederl: would this be where the NaN colour is currently being set?

pfederl commented 9 years ago

Correct. On Oct 29, 2015 16:01, "Jeff Taylor" notifications@github.com wrote:

@pfederl https://github.com/pfederl: would this https://github.com/Astroua/CARTAvis/blob/1efe006814c92287795b36c1fc9b3d16e21575fa/carta/cpp/core/ImageRenderService.cpp#L68 be where the NaN colour is currently being set?

— Reply to this email directly or view it on GitHub https://github.com/Astroua/CARTAvis/issues/103#issuecomment-152340722.

slovelan commented 9 years ago

This should be in my next check-in.