search

Astroua / CARTAvis

Deprecated Repository for CARTA project. Refer to:
https://github.com/cartavis/carta
GNU General Public License v2.0
2 stars 7 forks source link

performance : in movie mode, contour images and raster images are not synchronized #189

Open kswang1029 opened 7 years ago

kswang1029 commented 7 years ago

this is likely the performance issue. When contours are enabled and in the movie mode, the fps for the raster images is faster than the contour images. Ideally, the fps of the two should be the same (synchronized).

https://youtu.be/fcJQeyBhJO0

slovelan commented 7 years ago

I think this may already be fixed. I was NOT able to reproduce the issue from my branch, but when I reverted back to the develop branch I was able to reproduce the issue.

kswang1029 commented 7 years ago

Thanks, Susan. Anthony has helped to build your latest branch and indeed the raster and contour are synced in movie mode. :)

kswang1029 commented 7 years ago

Oh, this issue is back alive.

Indeed, with the default "analysis" layout, raster and contour are synced (same fps). However, if we open up one or two more images (or image cubes), or if we enable the profile/histogram per channel/image_context/image_zoom, the unsynced feature comes back.

slovelan commented 7 years ago

I am not able to reproduce the problem. Could you make available the images you are using as well as how you are generating the contours? Are you opening the images in the same window or different windows?

kswang1029 commented 7 years ago

Hi Susan, sorry for the late reply...

To reproduce the issue: 1) open orion_12co_hera.fits 2) in the clipping tab, disable "recompute clips on new frame" and select 100% clip level. 3) in the colormap panel, using linear with lower and upper limits to -5 and 110, respectively 4) add a new window and select "imagecontext" and make the "link" 5) in the image settings, make 10 contours from 20 to 100, change contour color to cyan for better visualization 6) now play the movie and we should see that the raster and contour are not synced. Let the movie show ~10 channels and stop the movie.

slovelan commented 7 years ago

Thank you for the reproduce details. The scenario described above should now be fixed.