search

AstuteSource / chasten

:dizzy: Chasten Uses XML and XPATH to Check a Python Program's AST for Specified Patterns!
https://pypi.org/project/chasten/
GNU General Public License v2.0
7 stars 8 forks source link

fix: Datasette-serve command not running correctly on Windows #52

Closed Poiuy7312 closed 10 months ago

Poiuy7312 commented 11 months ago

This adds a function in util.py called get_OS() which gets what the OS of the user so MacOS, Linux or Windows. This was implemented because there was an issue with the Datasette-serve command on windows would look in the wrong directory for the executable for datasette. So I changed to look in a different directory Scripts if its run on Windows and then it looks for them in the Bin file when run on anything else

I also added a function in database.py which creates a path to the executable which the function Datasette-serve previously did itself. This was done because it made it a lot easier to make sure that the added feature works as intended and allowed me to write a test case for it.

gkapfham commented 11 months ago

Hello @Poiuy7312, please note that you need to use the commit standard that we have adopted for this project: https://www.conventionalcommits.org/en/v1.0.0/.

gkapfham commented 11 months ago

Hello @Poiuy7312 your description of this PR needs to clearly explain what this will change in the main codebase and in the main tool once it is merged. Can you please furnish an example of what did not work before you made the changes and then what now does work if we merge this PR? You are also welcome to reference an issue in the issue tracker when you explain your PR.

gkapfham commented 11 months ago

Hello @Poiuy7312 is this PR fully updated so that it contains the new build matrix setup for running everything in GitHub Actions?

Poiuy7312 commented 11 months ago

Hello @Poiuy7312 is this PR fully updated so that it contains the new build matrix setup for running everything in GitHub Actions?

Yes

boulais01 commented 11 months ago

Hey @tuduun @gkapfham @jnormile would one of you mind giving this a look?

boulais01 commented 11 months ago

@tuduun We are still waiting on your review, when you get the chance.