Closed Bchass closed 10 months ago
Adding @tuduun to the review given that this will directly impact our testing strategy.
Hi @Bchass, thanks for your contribution! Some of your fixes in tests/test_main.py
appear to still perform file path concatenation by [str] + [Path]
. Would you be able to modify this in the following lines?
https://github.com/Bchass/chasten/blob/35fd8f6f3b760e6818107b9665e89008be13d348/tests/test_main.py#L94 https://github.com/Bchass/chasten/blob/35fd8f6f3b760e6818107b9665e89008be13d348/tests/test_main.py#L125 https://github.com/Bchass/chasten/blob/35fd8f6f3b760e6818107b9665e89008be13d348/tests/test_main.py#L147 https://github.com/Bchass/chasten/blob/35fd8f6f3b760e6818107b9665e89008be13d348/tests/test_main.py#L300
Hi @Bchass, thanks for your contribution! Some of your fixes in
tests/test_main.py
appear to still perform file path concatenation by[str] + [Path]
. Would you be able to modify this in the following lines?https://github.com/Bchass/chasten/blob/35fd8f6f3b760e6818107b9665e89008be13d348/tests/test_main.py#L94 https://github.com/Bchass/chasten/blob/35fd8f6f3b760e6818107b9665e89008be13d348/tests/test_main.py#L125 https://github.com/Bchass/chasten/blob/35fd8f6f3b760e6818107b9665e89008be13d348/tests/test_main.py#L147 https://github.com/Bchass/chasten/blob/35fd8f6f3b760e6818107b9665e89008be13d348/tests/test_main.py#L300
Ah, yes! I'll fix those lines later tonight.
Hi @Bchass everything looks good now, thank you! It seems that somehow, two rogue changes were pushed onto your branch, namely https://github.com/AstuteSource/chasten/pull/60/commits/eb3dff61216240871edf6b7da24d22f9591e8df3 and https://github.com/AstuteSource/chasten/pull/60/commits/7db0024fcc30f6e698f7cdfe47f0ded465799366.
Would you clean your branch's git history and purge these two commits?
Fix for: https://github.com/AstuteSource/chasten/issues/58
Looked for other possible conversions in unit tests.
Test results: