WIP: Feature: Allow `min` and `max` values in any checks file to have `null` value

AstuteSource / chasten

:dizzy: Chasten Uses XML and XPATH to Check a Python Program's AST for Specified Patterns!

https://pypi.org/project/chasten/

GNU General Public License v2.0

7 stars 8 forks source link

WIP: Feature: Allow `min` and `max` values in any checks file to have `null` value #68

Closed simojo closed 10 months ago

simojo commented 11 months ago

This PR changes the json schema used in validation of checks files, and it changes the pydantic BaseModel class structure. See the diffs for details. This is one of two steps towards PR https://github.com/AstuteSource/chasten/issues/59. The next step after this is to change the local checks file: .chasten/checks.yml, which will be merged after this PR is merged.

simojo commented 11 months ago

It's worth noting that this also ships a fix where

if min was null, then it would check if the number of checks is higher than max
if max was null, then it would check if the number of checks is lower than min

This is, of course, the opposite of the expected behavior. See commit https://github.com/AstuteSource/chasten/pull/68/commits/682f54c46fe2751d1802b53851f54fa971e6524b for this fix.

gkapfham commented 11 months ago

Hello @simojo, this check seems to be presenting a problem and, thus far, we've not had a team member devote the time to removing the tracking of test coverage and/or rewrite the tracking of test coverage. Your build is failing for this reason. What do you think is the best step forward?