search

AstuteSource / chasten

:dizzy: Chasten Uses XML and XPATH to Check a Python Program's AST for Specified Patterns!
https://pypi.org/project/chasten/
GNU General Public License v2.0
7 stars 8 forks source link

Fix: local checkfile used in testing is now general enough #69

Closed simojo closed 10 months ago

simojo commented 11 months ago

Previously, the local checkfile .chasten/checks.yml had checks searching for things like doubly-nested if statements found in the chasten source code. Because finding things like this in our repository source code is not set in stone, I have changed this to be general enough to effectively test the functionality without making false assumptions such as the one previously mentioned.

Closes https://github.com/AstuteSource/chasten/issues/59

NOTE: depends on #68 before merging.

NOTE: @gkapfham is pointing out that #68 has now been merged.

simojo commented 10 months ago

It appears that we're having problems with coverage here. I'll continue to look into this and comment what I find here. I was not expecting this. @laurennevill

laurennevill commented 10 months ago

Hey @gkapfham, this is priority one for merges

simojo commented 10 months ago

The problem with coverage is still unidentified and unsolved, just letting this thread know.

simojo commented 10 months ago

@laurennevill @gkapfham , Mordred and I found that the failing checks is a transient issue. I suspect that, because coverage is time consuming, the process is timing out, but this does not appear to be obvious anywhere. Regardless, we have proven that the issue is not consistent, and we both recommend merging this when possible.