search

AstuteSource / chasten

:dizzy: Chasten Uses XML and XPATH to Check a Python Program's AST for Specified Patterns!
https://pypi.org/project/chasten/
GNU General Public License v2.0
7 stars 8 forks source link

fix: removed filelines from sources class in db.py #71

Closed Poiuy7312 closed 11 months ago

Poiuy7312 commented 1 year ago

This is a fix for issue #50

The code still runs when removing the _filelines attribute:

Analyze:

image_2023-11-02_154601324

Integrate:

image_2023-11-02_154240473

Datasette-serve:

image_2023-11-02_154419880

laurennevill commented 12 months ago

Hey @gkapfham, this is priority 2.

gkapfham commented 11 months ago

Hello @tuduun, I think that the solution in this case is to remove filelines, which is what this PR actually does. Can you confirm @Poiuy7312?

Poiuy7312 commented 11 months ago

Yes it does just do that

On Wed, Nov 1, 2023, 16:49 Gregory M. Kapfhammer @.***> wrote:

Hello @tuduun https://github.com/tuduun, I think that the solution in this case is to remove filelines, which is what this PR actually does. Can you confirm @Poiuy7312 https://github.com/Poiuy7312?

— Reply to this email directly, view it on GitHub https://github.com/AstuteSource/chasten/pull/71#issuecomment-1789659812, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2ZWPMDJNHGRT2HBFUNJLLTYCKYT7AVCNFSM6AAAAAA5DCTKPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBZGY2TSOBRGI . You are receiving this because you were mentioned.Message ID: @.***>

gkapfham commented 11 months ago

@Poiuy7312 please note that I am not requested changes to the source code but rather to the PR itself. You can provide command-lines and/or screenshots to show the tool is still working after you have removed the variable from the list. Thanks!

laurennevill commented 11 months ago

Hey @Poiuy7312 , can you update this branch to master?