search

AstuteSource / chasten

:dizzy: Chasten Uses XML and XPATH to Check a Python Program's AST for Specified Patterns!
https://pypi.org/project/chasten/
GNU General Public License v2.0
7 stars 8 forks source link

fix: Changed encoding to utf-8 if default fails #78

Closed Poiuy7312 closed 9 months ago

Poiuy7312 commented 9 months ago

This fixes the bug from #77

simojo commented 9 months ago

@Poiuy7312 why not just use utf-8 always by default? Is there any reason preventing you from making that the default?

Poiuy7312 commented 9 months ago

That was my original plan but I didn't want to force it to use utf-8 if it doesn't have to other than that there is no real reason.

On Sat, Sep 30, 2023, 11:41 Simon Jones @.***> wrote:

@Poiuy7312 https://github.com/Poiuy7312 why not just use utf-8 always by default? Is there any reason preventing you from making that the default?

— Reply to this email directly, view it on GitHub https://github.com/AstuteSource/chasten/pull/78#issuecomment-1741793231, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2ZWPMHCSYC4EOMEY7DNBMLX5A4SBANCNFSM6AAAAAA5MPIDKY . You are receiving this because you were mentioned.Message ID: @.***>

gkapfham commented 9 months ago

Hi @Poiuy7312 can you please tag at least three reviewers?