search

Asuraxsoul / pe

0 stars 0 forks source link

The algorithm for Singapore ID seems to be incorrect #10

Open Asuraxsoul opened 4 years ago

Asuraxsoul commented 4 years ago

I think there is a legit algorithm to calculate singapore iD.

nus-se-bot commented 3 years ago

Team's Response

Not a valid bug report.

You can check the link here which says the algorithm is not released to the public.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The expected functionality of adding a patient with their NRIC is to check if their NRIC is valid or not. This check is implemented by your team, but was not implemented as expected, in other words, the checking algorithm is wrong.

This should either be stated in the UG to warn user about the expected checking algorithm, or the team should implement a checking algorithm that is as per expectation.

Yes, the algorithm might not be public, but there are many accurate NRIC checksum websites on the internet, and although their algorithm may not be the same as the one Singapore ICA use, the algorithms are available in open sources. https://ivantay2003.medium.com/creation-of-singapore-identity-number-nric-24fc3b446145

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: I feel that this is a very important bug especially if this NRIC is used as a unique ID to identify patients in the context of the application and also in the context of the hospital/clinics. I feel that the check should be more stringent.