search

Asuraxsoul / pe

0 stars 0 forks source link

Assign command date rounds down error #7

Open Asuraxsoul opened 4 years ago

Asuraxsoul commented 4 years ago

image.png

image.png

Actual: When an invalid date of eg <=31 was typed, example (29-02-2021, 31-04-2020), the program automatically rounds down to the latest valid date which is (28-02-2021, 30-04-2020)

Expected: Error message should appear as such date should not be processed and recorded.

nus-se-bot commented 3 years ago

Team's Response

This is actually a default behaviour of Java DateTimeFormatter where they resolve dates in an intelligent manner. It can be modified by setting the ResolverStyle from SMART to STRICT.

This feature also do not really cause an inconvenience to the user.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: I feel that the API is not at fault because we developers are adopting it. We should be clear about the input output of APIs. Date has to be precise in the case of making appointments especially for clinical appointments.

This bug causes inconvenience to the user. Remember that in the context of clinical/hospital appointments, date is of utmost importance.

This bug is actually an extensive one because every month in every year with less than 31 days will have the possibility of getting this bug. Once this bug happens and was not noticed by the user of the app, there will be a chain of negative effects of appointment clashes and rescheduling.