feat: Remove edit button when editing EditSection

AtB-AS / webshop

AtB Webshop / AtB Nettbutikk

https://nettbutikk.atb.no

European Union Public License 1.2

0 stars 1 forks source link

feat: Remove edit button when editing EditSection #380

Closed gorandalum closed 3 years ago

gorandalum commented 3 years ago

When the edit button was placed under the text content of the edit section, the destructive group was placed even further down, even though the edit button was not visible. This looked strange, especially on mobile devices.

github-actions[bot] commented 3 years ago

Visit the preview URL for this PR (updated for commit 7477275):

https://atb-webshop-staging--pr380-dalum-remove-edit-bu-9jmgrbzm.web.app

_{(expires Thu, 09 Sep 2021 09:09:05 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

gorandalum commented 3 years ago

Før endring / Etter endring

En bivirkning er at i visse tilfeller kan teksten flytte seg, siden det blir frigjort plass der hvor edit button var. Snakket med Tor Kjetil om det og vi fant ut at det ikke var noen krise. Eksempel:

Screenshot 2021-09-07 at 11 02 37

tormoseng commented 3 years ago

Testet OK