Prepare release v1.2

[codecov[bot]]

Codecov Report

Merging #422 into master will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #422   +/-   ##
=======================================
  Coverage   88.72%   88.72%           
=======================================
  Files          17       17           
  Lines        2262     2262           
=======================================
  Hits         2007     2007           
  Misses        255      255           

Flag	Coverage Δ
#build	62.45% <100.00%> (ø)
#tests	87.88% <100.00%> (ø)
#unittests	35.76% <100.00%> (ø)

Impacted Files	Coverage Δ
src/atchem2.f90	90.23% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 057fdff...6e07dbb. Read the comment docs.

[rs028]

@spco I have deleted most of the .gitignore files from the travis/tests subdirectory should not be needed and can be removed. However this creates a bunch of empty directories when constraints are not used in a test. Can/should these be removed too?

Also, I have commented out part of the printout message of travis/run_tests.sh because I think it is not actually used. The indent and style tests have their own printout messages. Can it be deleted altogether?

[spco]

On the subject of the empty directories, I can't remember whether they are needed or not - do the tests complete if they're removed? Remember that git only tracks files, not directories, so an empty directory will not be replicate if you clone the repo.

If the directories do need to be kept for the tests to run etc (or just to make it clear to users what the directory structure should be - they can just look in any test directory), then the usual convention is to put a blank .gitkeep file inside them, so that git can keep track of them. They're not special files like .gitignore, so git doesn't treat them any differently to any other file.

[rs028]

The tests pass without the empty directories. The question is, will they remain in the repository since I cannot push their deletion? The rationale for removing them is to simplify the addition of new tests.

[spco]

Directories are not tracked if empty, so they will not show up - there is nothing to delete.

Good point about making it easier to add new tests. Is there a test that uses all of the directories? It might be useful to be able to point users to a single canonical example where they're all used, just to make it clear what is there. Or I guess the relevant section in the manual could be used as the guide instead anyway?

[rs028]

Yes there are tests that use all directories. I think the manual is quite clear on how to add tests. In any case at some point we want to remake the whole test suite so that will be the moment to sort out these issues. I don't have time to work on the test suite now and I would like to have a new release fairly soon (btw I send you a bunch of messages on slack about that, don't know if you are checking it these days).

[rs028]

Why is this failing on macOS now?

[spco]

Have restarted it - the log is empty so it may just be a Travis issue.

[spco]

It's failed again in the same way. Nothing in their changelog since 9 days ago, so don't think it can be that. https://www.traviscistatus.com/ is showing no issues, but I think it's at their end. May have to wait a couple of hours and retry.

[rs028]

It was failing 2 days ago as well. It's not urgent, and at least it runs on Linux.

[rs028]

I think this is ready to go. I will wait a bit to merge while @mpanagi tests the solution to #413.

[mpanagi]

After the minor edits the model now compiles and runs and the results are the same.

[rs028]

Thanks @mpanagi.

If there is nothing else to add I will merge this and make a note somewhere about the travis tests for macOS.

[rs028]

Okay version 1.2 is now ready. Thanks to @spco, @bsn502, @mpanagi for your help and contributions!