search

AtChem / AtChem2

Atmospheric chemistry box-model for the MCM
MIT License
58 stars 23 forks source link

Start dev version #430

Closed rs028 closed 4 years ago

rs028 commented 4 years ago

This starts the new development cycle and fixes a couple of minor issues.

spco commented 4 years ago

You'll need to repeat https://github.com/AtChem/AtChem2/blob/e18a0341a11b4a9f7d57e46c2fd0a7c01cc18d85/src/inputFunctions.f90#L1268 now that mechanism.ro2 has 2 comment lines at the top that need skipping rather than 1 previously.

codecov[bot] commented 4 years ago

Codecov Report

Merging #430 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   88.72%   88.72%           
=======================================
  Files          17       17           
  Lines        2262     2262           
=======================================
  Hits         2007     2007           
  Misses        255      255
Flag Coverage Δ
#build 62.45% <100.00%> (ø)
#tests 87.88% <100.00%> (ø)
#unittests 35.76% <100.00%> (ø)
Impacted Files Coverage Δ
src/atchem2.f90 90.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a18fca...9f9263e. Read the comment docs.

rs028 commented 4 years ago

Easier to go back to a single line :)

But I don't understand why the tests were passing on my machine (?)

rs028 commented 4 years ago

@spco happy for me to merge this?

spco commented 4 years ago

Seems so!