search

AtChem / AtChem2

Atmospheric chemistry box-model for the MCM
MIT License
58 stars 23 forks source link

Fix missing code coverage files #444

Closed spco closed 3 years ago

spco commented 3 years ago

Use FORTC in Makefile.skel to test for the fortran compiler family (rather than the exact name of the executable). This should ensure code coverage is tracked on ubuntu Actions runs.

codecov[bot] commented 3 years ago

Codecov Report

Merging #444 (df3fdf0) into master (9372a30) will decrease coverage by 24.09%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #444       +/-   ##
===========================================
- Coverage   88.73%   64.63%   -24.10%     
===========================================
  Files          17       17               
  Lines        2264     2138      -126     
===========================================
- Hits         2009     1382      -627     
- Misses        255      756      +501
Flag Coverage Δ
build 51.03% <ø> (-11.47%) :arrow_down:
tests 82.55% <ø> (-5.35%) :arrow_down:
unittests 31.16% <ø> (-4.57%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/solverFunctions.f90 30.86% <0.00%> (-60.39%) :arrow_down:
src/outputFunctions.f90 48.12% <0.00%> (-41.19%) :arrow_down:
src/interpolationFunctions.f90 33.33% <0.00%> (-39.59%) :arrow_down:
src/dataStructures.f90 58.26% <0.00%> (-36.77%) :arrow_down:
src/constraintFunctions.f90 44.96% <0.00%> (-36.25%) :arrow_down:
src/inputFunctions.f90 55.04% <0.00%> (-31.27%) :arrow_down:
src/argparse.f90 38.57% <0.00%> (-26.18%) :arrow_down:
src/configFunctions.f90 80.76% <0.00%> (-9.43%) :arrow_down:
src/parameterModules.f90 92.75% <0.00%> (-7.25%) :arrow_down:
src/atmosphereFunctions.f90 62.96% <0.00%> (-6.01%) :arrow_down:
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a228279...df3fdf0. Read the comment docs.

spco commented 3 years ago

Frankly, I have no idea what's going on with this - the codecov results are much lower than previously, and I think it's because the unittests are not being correctly counted. But I've no idea what I'm doing wrong, and have spent too long it already!

I will make final commits this so it is at least up and running, but the coverage will be much lower than we saw before.