kilicomu commented 3 years ago

The CVODE releases have moved to GitHub - download URL has been updated and call to wget has been modified to save the archive to the filename that matches the rest of the installation script.

spco commented 3 years ago

Ugh, looks like Actions images have moved on and no longer supply gfortran 8 out of the box. I can raise a PR to remove gfortran-8 from the matrix of environments, though it would be good in future to continue to run tests on 8.

spco commented 3 years ago

I've remove gfortran-8 from the build matrix - could you rebase and run these again please @kilicomu ?

codecov[bot] commented 3 years ago

Codecov Report

Merging #454 (cf2b819) into master (9c06d09) will decrease coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
- Coverage   65.51%   65.46%   -0.05%     
==========================================
  Files          17       17              
  Lines        2047     2047              
==========================================
- Hits         1341     1340       -1     
- Misses        706      707       +1

Flag	Coverage Δ
build	`52.23% <100.00%> (ø)`
tests	`82.80% <100.00%> (-0.02%)`	:arrow_down:
unittests	`31.61% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/atchem2.f90	`87.68% <100.00%> (ø)`
src/interpolationFunctions.f90	`34.09% <0.00%> (-2.28%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 10eedfe...cf2b819. Read the comment docs.

spco commented 3 years ago

Ignore the codecov - it's now garbage. Thanks @kilicomu !

AtChem / AtChem2

Update CVODE download URL #454

Codecov Report