kilicomu commented 3 years ago

We aren't actually using LAPACK features of CVODE, and it complicates the build process. Disable LAPACK in the CVODE installation script with a view to investigating it when we migrate to a newer version of SUNDIALS.

Closes #458

codecov[bot] commented 3 years ago

Codecov Report

Merging #460 (8bc0795) into master (dd25104) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #460   +/-   ##
=======================================
  Coverage   65.51%   65.51%           
=======================================
  Files          17       17           
  Lines        2047     2047           
=======================================
  Hits         1341     1341           
  Misses        706      706

Flag	Coverage Δ
build	`52.23% <ø> (ø)`
tests	`82.81% <ø> (ø)`
unittests	`31.61% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd25104...8bc0795. Read the comment docs.

rs028 commented 2 years ago

I just realized I never merged this. Is it okay to go?

kilicomu commented 2 years ago

I think so - it passes CI builds and I can build it on my cluster and run it without issue!

AtChem / AtChem2

Disable LAPACK support in CVODE #460

Codecov Report