search

AtChem / AtChem2

Atmospheric chemistry box-model for the MCM
MIT License
58 stars 23 forks source link

New Testsuite (2) #465

Closed rs028 closed 2 years ago

rs028 commented 2 years ago

First tests for the new testsuite ~(do not run when make tests is executed)~.

codecov[bot] commented 2 years ago

Codecov Report

Merging #465 (a0609b8) into master (afc3896) will increase coverage by 10.16%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #465       +/-   ##
===========================================
+ Coverage   55.37%   65.54%   +10.16%     
===========================================
  Files          17       17               
  Lines        2046     2046               
===========================================
+ Hits         1133     1341      +208     
+ Misses        913      705      -208
Flag Coverage Δ
build 52.27% <0.00%> (+0.03%) :arrow_up:
tests 83.11% <0.00%> (?)
unittests 31.62% <0.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/inputFunctions.f90 55.02% <0.00%> (+18.94%) :arrow_up:
src/outputFunctions.f90 55.84% <0.00%> (+5.84%) :arrow_up:
src/parameterModules.f90 92.75% <0.00%> (+1.44%) :arrow_up:
src/atchem2.f90 87.68% <0.00%> (+2.53%) :arrow_up:
src/argparse.f90 28.12% <0.00%> (+3.90%) :arrow_up:
src/dataStructures.f90 58.06% <0.00%> (+8.06%) :arrow_up:
src/solverFunctions.f90 49.38% <0.00%> (+13.58%) :arrow_up:
src/constraintFunctions.f90 40.31% <0.00%> (+18.60%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 118c485...a0609b8. Read the comment docs.

rs028 commented 2 years ago

While implementing the new tests, I noticed that there are upgraded versions of openlibm and numdiff, so I have included that here. It seems to fail the tests on mac, but I am not sure if it is a caused by the upgrade or something else).

rs028 commented 2 years ago

When this is okay, I will merge it and add more tests in a separate PR, as this one already has a lot of changes.

rs028 commented 2 years ago

Now the original behavioural tests are renamed oldtests and the newly developed tests are being added to modeltests. Both sets of tests are running under the CI setup.

Eventually the oldtests will be deleted (if obsolete or redundant) and/or moved to modeltests.