Closed AlfredMayhew closed 2 years ago
Merging #467 (3aa07fb) into master (afc3896) will increase coverage by
0.02%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #467 +/- ##
==========================================
+ Coverage 55.37% 55.40% +0.02%
==========================================
Files 17 17
Lines 2046 2045 -1
==========================================
Hits 1133 1133
+ Misses 913 912 -1
Flag | Coverage Δ | |
---|---|---|
build | 52.27% <0.00%> (+0.03%) |
:arrow_up: |
unittests | 31.62% <0.00%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/inputFunctions.f90 | 36.13% <0.00%> (+0.05%) |
:arrow_up: |
src/outputFunctions.f90 | 50.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update afc3896...3aa07fb. Read the comment docs.
Are we happy to merge this? Looks all right to me.
Looks good to me!
Following discussion in #372.
I have also removed the ignoring of the first line in the
photolysisConstant.config
file, when read byinputFunctions.f90
.Changing the
inputFunctions.f90
file as discussed in #372 resulted in issues with theoutputFunctions.f90
file, which I believe I have also fixed. It's worth noting that when using at least one constant J value only the constant J values are output in thephotolysisRates.output
file. I assumed this was by design since thephotolysisConstant.config
overrides other photolysis rates and sets them to 0 (even if they are specified as constrained), e.g. giving a value of 1E-5 for J1 inphotolysisConstant.config
and listing J2 inphotolysisConstrained.config
will result in a model where J1 = 1E-5 throughout and J2 = 0, regardless of what the J2 constraint file says.Hopefully this is all OK and makes sense, let me know if there's anything else that needs changing.