AtChem / AtChem2

Atmospheric chemistry box-model for the MCM
MIT License
59 stars 23 forks source link

Fix plotting tools #490

Closed rs028 closed 1 year ago

rs028 commented 1 year ago

A little time to kill in between flights... this is meant to resolve the issues in #269.

codecov[bot] commented 1 year ago

Codecov Report

Merging #490 (d7a20b6) into master (739879e) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/AtChem/AtChem2/pull/490/graphs/tree.svg?width=650&height=150&src=pr&token=4p5Cr68G8w&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AtChem)](https://codecov.io/gh/AtChem/AtChem2/pull/490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AtChem) ```diff @@ Coverage Diff @@ ## master #490 +/- ## ======================================= Coverage 66.81% 66.81% ======================================= Files 17 17 Lines 2046 2046 ======================================= Hits 1367 1367 Misses 679 679 ``` | Flag | Coverage Δ | | |---|---|---| | build | `52.81% <ø> (ø)` | | | tests | `67.17% <ø> (ø)` | | | unittests | `54.86% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AtChem#carryforward-flags-in-the-pull-request-comment) to find out more. ------ [Continue to review full report in Codecov by Sentry](https://codecov.io/gh/AtChem/AtChem2/pull/490?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AtChem). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AtChem) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/AtChem/AtChem2/pull/490?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AtChem). Last update [739879e...d7a20b6](https://codecov.io/gh/AtChem/AtChem2/pull/490?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AtChem). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AtChem).
rs028 commented 1 year ago

@spco, this is starting to be annoying... in PR #482, all the macos tests fail. On this PR only one test for macos12 fails (and for a different reason... the codebase is basically the same! 😡

rs028 commented 1 year ago

I will merge this, even though thte tests fails, since it only changes the plotting tools, which are independent from the rest of the code.