Closed rs028 closed 1 year ago
Merging #497 (25cd946) into master (457b3e4) will not change coverage. Report is 2 commits behind head on master. The diff coverage is
100.00%
.
All modified lines are covered by tests :white_check_mark:
Comparison is base (
4373dc9
) 52.00% compared to head (7d1fdc1
) 52.05%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The procedure involves a new script kpp_conversion.py
which converts the mechanism in KPP format to a .fac
file, which is then processed as usual. Possibly not the most efficient way to do it, but the easiest to implement.
This only works for the KPP files created by the MCM website. There is a large variability in the possible format of kpp files so it is hard to do better without specific examples.
Two new tests are also added to verify that the conversion is correct: a reference test with a normal fac mechanism and an identical (ie using same config) test using a kpp mechanism. They give the same results.
I think this all makes sense. On formatting and style, I have thoughts we should use existing external tools rather than rolling our own if possible - will create a separate issue.
@spco thanks a lot!
This will let the model use chemical mechanisms in KPP format (issue #304).
Also includes minor and cosmetic changes to the Python scripts in
build/
andtools/
(checked using pylint) and to some bash scripts.This also changes the version number back to development towards the 1.3 release (
1.3-dev
).