search

AtChem / AtChem2

Atmospheric chemistry box-model for the MCM
MIT License
59 stars 23 forks source link

consistent naming of Environment Variables #83

Closed rs028 closed 7 years ago

rs028 commented 7 years ago

The Environment variables dont' have a consistent naming. In the table below are the names in the config files (in modelConfiguration) and in the code. The FACSIMILE format generally follows the naming of the config files:

config code
M m
TEMP temp
H2O h2o or H2o
DEC dec
PRESS pressure
RH rh
BLHEIGHT blh
DILUTE dilute
JFAC jfac or JFac
ROOFOPEN roofOpen

This could be only a cosmetic thing (as Fortran is case insensitive, in which case is only relatively important) or it could be useful to have different names for the input options in the config files and for the variables in the code. Then what is the relationship the names in the FACSIMILE file? I don't have a preference, but it should be consistent. What is best practice?

(this may be related to issue #3)

rs028 commented 7 years ago

This does not affect the way the code works, so it is to be addressed in the wiki: https://github.com/AtChem/AtChem/wiki/Style-Guide