search

Atalanta / cucumber-chef

Framework for test-driven infrastructure development
http://cucumber-chef.org
Apache License 2.0
265 stars 55 forks source link

@output is now an OpenStruct #102

Closed pikesley closed 11 years ago

pikesley commented 11 years ago

where it used to be a string. This broke some of my old ssh_steps tests. I've now worked out what an OpenStruct actually is, and fixed the "package foo should be installed" assertion. I will fix up others as I hit them. There may be a case for some gentle refactoring somewhere down the road, but let's get this stuff working first.

Also, I've added the .idea/ directory from RubyMine to .gitngnore.

zpatten commented 11 years ago

Oh sorry; I thought I had fixed all of these!

pikesley commented 11 years ago

No worries, I've learned a bunch of stuff about OpenStructs this afternoon :)

pikesley commented 11 years ago

Aha, I see what you did there. OK, will rework this and make a new PR tomorrow. Feel free to bin this one :)

zpatten commented 11 years ago

Just go ahead and update this PR; I'll leave it open

zpatten commented 11 years ago

Ya I like OpenStructs because you get the member accessors; a lot nicer than having to deal with hash keys.

pikesley commented 11 years ago

OK, this is slightly more elegant now ;)