search

Atalanta / cucumber-chef

Framework for test-driven infrastructure development
http://cucumber-chef.org
Apache License 2.0
265 stars 55 forks source link

Windows compatibility #126

Closed Aigeruth closed 11 years ago

Aigeruth commented 11 years ago

Changed Unix/Linux commands to Ruby alternatives.

zpatten commented 11 years ago

Nice work!

zpatten commented 11 years ago

@Aigeruth I haven't forgotten about you; going to release a patch version of the gem with your changes here in a few.

Aigeruth commented 11 years ago

@zpattern No problem. It still doesn't work on Windows, because ztk/lib/ztk/command.rb uses Process.Fork() and this is not implemented on Windows. IMHO it should use childprocess like Vagrant does. I made a dirty version with childprocess, but I didn't have time to test it properly. That is why I haven't sent PR yet.

zpatten commented 11 years ago

I am not opposed to this; as long as we can maintain the same functionality. I'll take a look. If you have some code already done that you can gist/PR me I would appreciate it (anything that saves me time).

zpatten commented 11 years ago

@Aigeruth Go ahead and open an issue over on my ZTK repo for this.