search

Atalanta / cucumber-chef

Framework for test-driven infrastructure development
http://cucumber-chef.org
Apache License 2.0
265 stars 55 forks source link

Environments and Roles can be JSON as well as Ruby #133

Open pikesley opened 10 years ago

pikesley commented 10 years ago

I was attempting to use Etsy's rather nice knife-spork tool, but it blew up because it expects environments as JSON, not as Ruby, so I changed the env in question over to JSON and then my cuke-chef runs started failing spectacularly because it was only uploading the *.rb envs.

Hence this. And it's also valid for a role to be JSON, too, of course.

zpatten commented 10 years ago

Nice! Just see my one little comment there; looks like a little typo.

pikesley commented 10 years ago

Fixed. It's been a long day (also I'm sometimes an idiot)

;)

pikesley commented 10 years ago

Oh dammit. It fails if there are no JSON files present. I'll add some kind of checking around this.

pikesley commented 10 years ago

OK, try that for size :)

pikesley commented 10 years ago

I think this works now...