total_values_in_one_chunck variable definition

Atcold / NYU-DLSP20

NYU Deep Learning Spring 2020

https://atcold.github.io/NYU-DLSP20/

Other

6.66k stars 2.22k forks source link

Closed mohammedkhalfan closed 2 years ago

mohammedkhalfan commented 2 years ago

total_values_in_one_chunck should be a variable, not a param for EchoData().

review-notebook-app[bot] commented 2 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Atcold commented 2 years ago

How was the previous code even running, when the variable was defined within the data generating function?

mohammedkhalfan commented 2 years ago

How was the previous code even running, when the variable was defined within the data generating function?

It wasn't! It was breaking with this error TypeError: __init__() got an unexpected keyword argument 'total_values_in_one_chunck'