Atcold / NYU-DLSP20

NYU Deep Learning Spring 2020
https://atcold.github.io/NYU-DLSP20/
Other
6.66k stars 2.22k forks source link

week 6, ch 6.3 #817

Closed p-mishra1 closed 2 years ago

p-mishra1 commented 2 years ago

image

The equation and the image do not support each other, in the image the input x[t-1] should be x[t] as mentioned in the equation @Atcold .

Atcold commented 2 years ago

Central column of the right image: h[t] = f(h[t-1], x[t]). Which means, the current hidden state is function of the previous hidden state & the current input variable. What does not look correct to you?

p-mishra1 commented 2 years ago

yes exactly the equation is correct but in the model diagram both the hidden state as well as the input are of same time stamp h[t] = g(h[t-1], x[t-1]) this is what is mentioned in the model diagram. am i missing something here? i am unable to associate hidden states with the arrows should it be associated with upper arrow(what you are mentioning i suppose) or arrow coming from left(what i am referring to). So i think the diagram is ambiguous.

Atcold commented 2 years ago

I see. The h[t-1], h[t], and h[t+1] should be ‘inside’ the circle, but they don't fit, so they are placed outside. Last year I drew a better version of this diagram.

image

You can see the full tweet here.