search

Atcold / NYU-DLSP20

NYU Deep Learning Spring 2020
https://atcold.github.io/NYU-DLSP20/
Other
6.66k stars 2.22k forks source link

[DLSP22] typo in 16-gated_GCN.ipynb #820

Closed lcqsigi closed 2 years ago

lcqsigi commented 2 years ago

batch_x_e

batch_scores = model(batch_graphs, batch_X, batch_E, batch_snorm_n, batch_snorm_e) print(batch_scores.size())

batch_labels = batch_labels print(f'accuracy: {accuracy(batch_scores, batch_labels)}')

torch.Size([10, 8]) accuracy: 10

Atcold commented 2 years ago

Can you describe the issue?

lcqsigi commented 2 years ago

Upon running this notebook (i.e., 16-gated_GCN.ipynb) with python version 3.9.7, torch version 1.10.2, jupyter-notebook version 6.4.5, and dgl version 0.6.0, cell # 15 of the notebook prints: NameError: name 'batch_x' is not defined. If one replaces, the batch_scores definition with batch_X and batch_E in cell # 15 of the original 16-gated_GCN.ipynb notebook, the notebook runs to completion reporting a test_acc: 0.9900 after 40 Epochs.

Atcold commented 2 years ago

Oh, oh, I see, it's just a typo you fixed in #821. Cool, thanks.