[DLFL22] Clarify data "dependencies" in 09-echo_data.

Atcold / NYU-DLSP20

NYU Deep Learning Spring 2020

https://atcold.github.io/NYU-DLSP20/

Other

6.66k stars 2.22k forks source link

[DLFL22] Clarify data "dependencies" in 09-echo_data. #830

Closed pscollins closed 1 year ago

pscollins commented 1 year ago

Add comments to explain that successive batches are not independent.
Reset hidden state whenever EchoData state is reset.
Expand the final "example" section to make it easier to read out when the model is correct.
Use a fixed numpy seed for reproducibility.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

pscollins commented 1 year ago

(My git is a bit rusty -- not sure if the convention is to squash the fixes into the original commit or add a new one, hope that squashing was the right thing to do)

Atcold commented 1 year ago

(My git is a bit rusty -- not sure if the convention is to squash the fixes into the original commit or add a new one, hope that squashing was the right thing to do)

I do the squashing when everything looks alright 😉