Atcold / NYU-DLSP20

NYU Deep Learning Spring 2020
https://atcold.github.io/NYU-DLSP20/
Other
6.66k stars 2.22k forks source link

fixed up one level dir typo #839

Closed TernaryM01 closed 12 months ago

TernaryM01 commented 1 year ago

'./data' should be '../data', as also the case in 06-convnet.ipynb which downloads the same MNIST data. Previously, the code would re-download the same data.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

TernaryM01 commented 1 year ago

Sorry for the excessive number of commits... This is my first ever pull request on GitHub. The resultant diff is in fact only 2 characters.

Atcold commented 1 year ago

I see. We should not write content in one folder up with the convolutional notebook. Creating a data/ folder within the repo makes more sense. What do you think?

Atcold commented 12 months ago

I've updated convnet to download into ./data.