Closed dqian3 closed 1 week ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Just a heads up, you can review notebook changes like this using GitNotebooks.
e.g. this pull request https://gitnotebooks.com/Atcold/NYU-DLSP20/pull/846
It allows inline comments on code and markdown, and it's free for public repos so I thought I'd share..
@Atcold Pretty similar but it's a bit more performant, supports multi-line comments, and code comments appear inline like GitHub
@smith-kyle, I'm not sure why you're telling me this on this PR, though.
This is great, @dqian3! I should have updated this code a while ago. Moreover, a student just completed the notebook. I'll push that soon here, as soon as it's polished enough.
@Atcold thanks for merging this in! Would be very curious to see what ended up needing to change to finish the notebook, I remember I took a stab at it a while ago but got caught up on some issues with the simulation network.
Was trying to get the truck backer upper working as shown in the NYU Deep Learning class, but rather than downgrade jupyter and matplotlib, I figured out what needed to be changed to make the the notebook work with the latest version.
Tested with a fresh conda install, but haven't tried the other notebooks.
Summary of changes:
matplotlib.patches.Rectangle
pylab
imports with pythonrandom
andmath
modules.truck_backer-upper
=>truck_backer_upper
%matplotlib notebook