search

Atcold / NYU-DLSP20

NYU Deep Learning Spring 2020
https://atcold.github.io/NYU-DLSP20/
Other
6.66k stars 2.22k forks source link

[DLFL23] 14-truck_backer_upper.ipynb - Fix oudated matplotlib API usage #846

Closed dqian3 closed 1 week ago

dqian3 commented 9 months ago

Was trying to get the truck backer upper working as shown in the NYU Deep Learning class, but rather than downgrade jupyter and matplotlib, I figured out what needed to be changed to make the the notebook work with the latest version.

Tested with a fresh conda install, but haven't tried the other notebooks.

Summary of changes:

review-notebook-app[bot] commented 9 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

smith-kyle commented 7 months ago

Just a heads up, you can review notebook changes like this using GitNotebooks.

e.g. this pull request https://gitnotebooks.com/Atcold/NYU-DLSP20/pull/846

It allows inline comments on code and markdown, and it's free for public repos so I thought I'd share..

Atcold commented 2 months ago

@smith-kyle, how is it any different from ReviewNB?

smith-kyle commented 2 months ago

@Atcold Pretty similar but it's a bit more performant, supports multi-line comments, and code comments appear inline like GitHub

Atcold commented 2 months ago

@smith-kyle, I'm not sure why you're telling me this on this PR, though.

Atcold commented 1 week ago

This is great, @dqian3! I should have updated this code a while ago. Moreover, a student just completed the notebook. I'll push that soon here, as soon as it's polished enough.

dqian3 commented 1 week ago

@Atcold thanks for merging this in! Would be very curious to see what ended up needing to change to finish the notebook, I remember I took a stab at it a while ago but got caught up on some issues with the simulation network.