search

Atelaes / Mynda

An electron based media library
0 stars 0 forks source link

When downloading artwork from OMDb query, sometimes downloading message fails to disappear #13

Closed JohnMTorgerson closed 3 years ago

JohnMTorgerson commented 4 years ago

Specifically, in the ipcRenderer.on('downloaded',...) callback in MynEditArtwork (beginning line 2282 in current commit), the references this.input.current and this.dlMsg.current are undefined. Sometimes. Other times it seems to work fine. Unable to reproduce consistently. When they are undefined and an error is thrown, the "Downloading..." message persists and the user input field does not re-appear.

JohnMTorgerson commented 3 years ago

'Fixed' this by just putting those lines in a try block and finding the elements from the DOM as a fallback. This solves the problem and will work fine, so I'm closing the issue, even though it's kind of just a band-aid.