Atelaes / Mynda

An electron based media library
0 stars 0 forks source link

Error in MynEditorEdit when saving after changing the video's collections #42

Closed JohnMTorgerson closed 3 years ago

JohnMTorgerson commented 3 years ago

Apparently no video object is being passed to MynEditorEdit after saving, but only when saving after editing the collections of that video.

JohnMTorgerson commented 3 years ago

Was passing a null object to the details pane when saving a collections change. Previously this must have been overridden by something, but now it just results in nothing being sent to the details or the editor pane, as one would expect. The reason for doing it in the first place was that updating the details pane with the same video no longer caused the editor to render the saved changes, because we no longer include the collections information in the video object, so if all that was changed was the collections, it was registering that nothing changed. Fixed that by adding an explicit check for the collections information in the componentDidUpdate method of MynEditor