search

Atelier-Shiori / malupdaterosx-cocoa

Native MyAnimeList Scrobbler for macOS
https://malupdaterosx.moe/malupdaterosx/
BSD 3-Clause "New" or "Revised" License
24 stars 3 forks source link

MAL Updater tries to scrobble on a non-video page on Crunchyroll #36

Closed mlindner closed 7 years ago

mlindner commented 7 years ago

When viewing this page http://www.crunchyroll.com/videos/anime/seasons/spring-2017 the program tries to scrobble this as a title and fails and asks for suggestions for an anime titled "Crunchyroll".

moyitpro commented 7 years ago

It seems to be one of the regular expressions rules which can detect urls like

http://www.crunchyroll.com/trinity-seven/trinity-seven-eternity-library-alchemic-girl-trinity-seven-eternity-library-alchemic-girl-732735?t=0

Of course it will bring back false positives. If you can come up with a better rule that reduce the false positives, it will be great.

https://github.com/Atelier-Shiori/detectstream/blob/master/detectstream/MediaStreamParse.m

Sent from my iPhone 6 (Shijou Takane - 四条貴音)

On Apr 25, 2017, at 12:06 AM, mlindner notifications@github.com wrote:

When viewing this page http://www.crunchyroll.com/videos/anime/seasons/spring-2017 the program tries to scrobble this as a title and fails and asks for suggestions for an anime titled "Crunchyroll".

― You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

moyitpro commented 7 years ago

Fixed with https://github.com/Atelier-Shiori/detectstream/commit/21debd354f9ca1ce08c33c1b48e20eb61806c7cd

Added check to see if the title is "Crunchyroll". If so, it will ignore that tab.