AtelierArith / Replay.jl

Replay your REPL instructions
https://atelierarith.github.io/Replay.jl/dev/
MIT License
37 stars 3 forks source link

Fix asciinema player #68

Closed hyrodium closed 1 year ago

hyrodium commented 1 year ago

This PR fixes https://github.com/AtelierArith/Replay.jl/issues/67. I also added SIXEL examples to the documentation.

hyrodium commented 1 year ago

Should we fix the formatting, or can I relax the line-length limitation in .JuliaFormatter? I personally think the formatted code is hard to read.

Before formatting image

After formating image

terasakisatoshi commented 1 year ago

After formating

(EDIT) I personally like this result.

It behaves the same way as black formatter.

hyrodium commented 1 year ago

I personally like this result.

It behaves the same way as black formatter.

Okay, I have updated make.jl to adapt the current format config:+1:

Btw, both blue style and sciml style have 92 character line length limit, so I thought the limit is a bit short.

terasakisatoshi commented 1 year ago

Btw, both blue style and sciml style have 92 character line length limit, so I thought the limit is a bit short.

Got it. I've created #69

terasakisatoshi commented 1 year ago

It's time to merge this #68 pull request. And then, #69 ?

terasakisatoshi commented 1 year ago

🚀

terasakisatoshi commented 1 year ago

It works (on 2023-04-23)

image
hyrodium commented 1 year ago

But there is now a cutting-off lines problem.. (x-ref: https://github.com/AtelierArith/Replay.jl/pull/60#issuecomment-1513045362)