search

Atem18 / isocodes

This project provides lists of various ISO standards (e.g. country, language, language scripts, and currency names) in one place
GNU Lesser General Public License v2.1
14 stars 4 forks source link

isocodes.languages.get(name="Spanish") is {} #194

Closed ekalosak closed 1 year ago

ekalosak commented 1 year ago

Thank you for pushing pycountry into the future!! I have a bug to report.

Using latest isocodes, Python 3.11.4

import isocodes
assert isocodes.languages.get(name="Spanish")

^ the assert fails.

Direct string matches are a pain 😅 Here's the line that shows the data has "Spanish; ..." rather than "Spanish" alone. Something like iso639's match functionality would supercharge this library.

Atem18 commented 1 year ago

@ekalosak Thanks a lot for the bug report, I will have a look.

Atem18 commented 1 year ago

@ekalosak This should be fixed in the version 2023.08.29.

ekalosak commented 1 year ago

See PR comment; tl;dr that PR fixes the issue but is still brittle. Thank you!!!!

Atem18 commented 1 year ago

See PR comment; tl;dr that PR fixes the issue but is still brittle. Thank you!!!!

No problem, thanks for using this library ! :)