search

AtesComp / rdf-transform

RDF Transform is an extension for OpenRefine to transform data into RDF formats.
Other
28 stars 7 forks source link

Dialog loading is confused by new license comments #18

Closed AtesComp closed 2 years ago

AtesComp commented 2 years ago

Support HTML files containing the new license text as a comment, "\", adds an additional HTML element that confuses the bind processing after the loadHTML() call. The JQuery object no longer points to the dialog as element 0 (the only element).

AtesComp commented 2 years ago

Fix by using (and setting if one did not exist) a unique class name for the top dialog tag (div, table) as a JQuery filter on the returned load. The filter resolves to the proper element (generally index 2) for processing by the DOM.bind() call to get the internal "bind" elements bound to the JS code "elements" variable.

Fixed with https://github.com/AtesComp/rdf-transform/commit/2da2ede47cb5736a8c9421b4aa607392030e0e1d