search

Atforestry / fetch-data

MIT License
0 stars 0 forks source link

Pending items #6

Open borjagomez opened 2 years ago

borjagomez commented 2 years ago

We need to complete the following items:

  1. Separation of concerns: The endpoint fetch_mosaics shouldn't require any parameter as batch-run should not need to code any business logic on its side. The following parameters should be solved the following way:

    • Mosaic name: Constant in the code (optionally in the environment variable file)
    • Lat & Lang: Constants in the code (optionally in the environment variable file)
    • Date: The microservce should be able to determine what's the latest month available and download that month (i.e. June 2022 is not yet available; the last month available is April 2022)

  2. The microservice should remove the data downloaded after copying all the files to the cloud storage bucket. If we don't remove it will crash after several months.

  3. We need to add to the README.md that we need a working Google Service Account JSON with access to Google CS buckets in the root of the project for the microservice to work.

borjagomez commented 2 years ago

1 and 3 are solved already.

borjagomez commented 2 years ago

I've also removed async from FastApi endpoints. This way the server doesn't get blocked.