search

AthanorLabs / atomic-swap

💫 ETH-XMR atomic swap implementation
GNU Lesser General Public License v3.0
344 stars 44 forks source link

update contract to allow setting t0/t1 separately #364

Closed noot closed 1 year ago

noot commented 1 year ago

related to #357

will open for review after #363 is merged so I can redeploy the contract onto sepolia

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.39 :tada:

Comparison is base (aa70b55) 54.29% compared to head (06443f0) 54.69%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #364 +/- ## ========================================== + Coverage 54.29% 54.69% +0.39% ========================================== Files 93 93 Lines 7967 7931 -36 ========================================== + Hits 4326 4338 +12 + Misses 3097 3050 -47 + Partials 544 543 -1 ``` | [Impacted Files](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [ethereum/check\_swap\_factory\_contract.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZXRoZXJldW0vY2hlY2tfc3dhcF9mYWN0b3J5X2NvbnRyYWN0Lmdv) | `58.00% <ø> (ø)` | | | [common/config.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y29tbW9uL2NvbmZpZy5nbw==) | `73.73% <100.00%> (ø)` | | ... and [88 files with indirect coverage changes](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/364/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

noot commented 1 year ago

@dimalinux yes, I'm not totally sure if we should change the timeouts yet, especially considering when relayers are used.