codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 100.00% and project coverage change: -0.62 :warning:
Comparison is base (
0a90f6b) 58.75% compared to head (cac4107) 58.13%.:exclamation: Current head cac4107 differs from pull request most recent head 54d5c34. Consider uploading reports for the commit 54d5c34 to get more accurate results
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #392 +/- ## ========================================== - Coverage 58.75% 58.13% -0.62% ========================================== Files 119 119 Lines 10607 10929 +322 ========================================== + Hits 6232 6354 +122 - Misses 3685 3891 +206 + Partials 690 684 -6 ``` | [Impacted Files](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [daemon/test\_support.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/392?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGFlbW9uL3Rlc3Rfc3VwcG9ydC5nbw==) | `99.27% <100.00%> (ø)` | | ... and [25 files with indirect coverage changes](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/392/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
dimalinux
I wasn't able to replicate issue385 in a unit test, but I am seeing what looks like the same issue when cancelling Alice's server before she completes the transfer from the temporary swap wallet back to her primary wallet. In the included test, she's not recovering successfully on server restart, although, in theory, she has the necessary pieces of information to complete the swap on server restart.
This branch is only for playing with the issue and not intended for merging without significant changes.