Closed stubbrn closed 1 year ago
Patch coverage: 45.45
% and project coverage change: -0.29
:warning:
Comparison is base (
606f80f
) 59.13% compared to head (aff243e
) 58.84%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
since the mainnet contract isn't deployed yet, we should probably merge this after that's done (which should be very soon!)
Thanks for the work and getting us to figure out the small details for the complete fix! I'm closing this PR, as https://github.com/AthanorLabs/atomic-swap/pull/427 ending up fixing the issue.
closes #365
What should I do for mainnet?
SwapCreatorAddr
is "0x" andForwarderAddr
is used inCheckForwarderContractCode
https://github.com/AthanorLabs/atomic-swap/blob/ea8bae1416c2c4fad8a5a30cb03118675a52994e/common/config.go#L70-L72 https://github.com/AthanorLabs/atomic-swap/blob/ea8bae1416c2c4fad8a5a30cb03118675a52994e/ethereum/check_swap_creator_contract.go#L116