AthanorLabs / atomic-swap

💫 ETH-XMR atomic swap implementation
GNU Lesser General Public License v3.0
345 stars 44 forks source link

fix: set `GasLimit` for relayed transactions #425

Closed noot closed 1 year ago

noot commented 1 year ago

closes #422 closes #343 (should re-open another issue regarding second case) I can pull this into another PR if desired, I added it here since I needed it for testing

also fix setting of nextExpectedEvent to XMRLocked in xmrmaker, a restart during the transfer step caused the node to think nothing was locked on restart.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 51.06% and project coverage change: -0.52 :warning:

Comparison is base (caa5251) 60.22% compared to head (14362d1) 59.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #425 +/- ## ========================================== - Coverage 60.22% 59.71% -0.52% ========================================== Files 120 120 Lines 10820 10854 +34 ========================================== - Hits 6516 6481 -35 - Misses 3592 3667 +75 + Partials 712 706 -6 ``` | [Impacted Files](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [protocol/xmrmaker/event.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHJvdG9jb2wveG1ybWFrZXIvZXZlbnQuZ28=) | `72.78% <ø> (+1.36%)` | :arrow_up: | | [protocol/xmrtaker/claim.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHJvdG9jb2wveG1ydGFrZXIvY2xhaW0uZ28=) | `34.88% <40.00%> (-29.32%)` | :arrow_down: | | [protocol/xmrmaker/claim.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHJvdG9jb2wveG1ybWFrZXIvY2xhaW0uZ28=) | `56.95% <48.38%> (-2.03%)` | :arrow_down: | | [protocol/xmrmaker/swap\_state.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHJvdG9jb2wveG1ybWFrZXIvc3dhcF9zdGF0ZS5nbw==) | `67.71% <57.14%> (+0.39%)` | :arrow_up: | | [relayer/submit\_transaction.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cmVsYXllci9zdWJtaXRfdHJhbnNhY3Rpb24uZ28=) | `65.92% <66.66%> (+0.01%)` | :arrow_up: | | [net/relay.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bmV0L3JlbGF5Lmdv) | `72.83% <100.00%> (ø)` | | ... and [9 files with indirect coverage changes](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/425/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.