codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 69.23% and project coverage change: +1.06 :tada:
Comparison is base (
0b59d9a) 59.48% compared to head (f200eb3) 60.54%.:exclamation: Current head f200eb3 differs from pull request most recent head 7413bbd. Consider uploading reports for the commit 7413bbd to get more accurate results
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #427 +/- ## ========================================== + Coverage 59.48% 60.54% +1.06% ========================================== Files 120 120 Lines 10795 10818 +23 ========================================== + Hits 6421 6550 +129 + Misses 3669 3558 -111 - Partials 705 710 +5 ``` | [Impacted Files](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [daemon/test\_support.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZGFlbW9uL3Rlc3Rfc3VwcG9ydC5nbw==) | `99.26% <ø> (-0.01%)` | :arrow_down: | | [pricefeed/pricefeed.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHJpY2VmZWVkL3ByaWNlZmVlZC5nbw==) | `53.24% <ø> (ø)` | | | [rpc/swap.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cnBjL3N3YXAuZ28=) | `17.00% <0.00%> (-0.18%)` | :arrow_down: | | [protocol/xmrtaker/swap\_state.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHJvdG9jb2wveG1ydGFrZXIvc3dhcF9zdGF0ZS5nbw==) | `69.58% <56.25%> (+3.07%)` | :arrow_up: | | [tests/ganache.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dGVzdHMvZ2FuYWNoZS5nbw==) | `80.72% <72.72%> (-2.89%)` | :arrow_down: | | [ethereum/check\_swap\_creator\_contract.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZXRoZXJldW0vY2hlY2tfc3dhcF9jcmVhdG9yX2NvbnRyYWN0Lmdv) | `71.15% <90.90%> (+6.15%)` | :arrow_up: | | [common/config.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y29tbW9uL2NvbmZpZy5nbw==) | `85.71% <100.00%> (-0.26%)` | :arrow_down: | ... and [13 files with indirect coverage changes](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/427/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
The
go-relayerproject has been updated to have bindings for a gsnforwarder that is bytecode identical to the mainnet forwarder, deployed by opengsn (which we are using). The forwarder we were previously using in dev/stagenet was compiled with a different version of solidity and had subtle source code differences from the one deployed on mainnet.The gsnforwarder changes in
go-relayerwill be merged and tagged first. Reviewing those changes is part of reviewing this PR: https://github.com/AthanorLabs/go-relayer/pull/13Since I would have needed to update the environment configs anyways, I removed their references in the config: closes https://github.com/AthanorLabs/atomic-swap/issues/365
@stubbrn Apologies for stealing a PR out from under you. Since you already started working on the issue, your review on these code changes would be helpful/appreciated.