AthanorLabs / atomic-swap

💫 ETH-XMR atomic swap implementation
GNU Lesser General Public License v3.0
345 stars 44 forks source link

feat: close stream after NotifyETHLocked is sent #446

Closed noot closed 1 year ago

noot commented 1 year ago

closes #431

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 69.43% and project coverage change: +0.47 :tada:

Comparison is base (b3dcb96) 57.94% compared to head (5d52c69) 58.41%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #446 +/- ## ========================================== + Coverage 57.94% 58.41% +0.47% ========================================== Files 124 123 -1 Lines 11601 11576 -25 ========================================== + Hits 6722 6762 +40 + Misses 4149 4096 -53 + Partials 730 718 -12 ``` | [Impacted Files](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [cmd/swapd/main.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y21kL3N3YXBkL21haW4uZ28=) | `67.20% <ø> (-1.35%)` | :arrow_down: | | [protocol/xmrtaker/claim.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHJvdG9jb2wveG1ydGFrZXIvY2xhaW0uZ28=) | `59.25% <ø> (+24.37%)` | :arrow_up: | | [protocol/xmrmaker/net.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHJvdG9jb2wveG1ybWFrZXIvbmV0Lmdv) | `50.44% <16.66%> (-2.39%)` | :arrow_down: | | [ethereum/swap\_creator.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZXRoZXJldW0vc3dhcF9jcmVhdG9yLmdv) | `8.02% <40.00%> (+0.05%)` | :arrow_up: | | [protocol/xmrmaker/event.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHJvdG9jb2wveG1ybWFrZXIvZXZlbnQuZ28=) | `71.52% <40.00%> (-1.27%)` | :arrow_down: | | [net/relay.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bmV0L3JlbGF5Lmdv) | `57.93% <47.45%> (-10.64%)` | :arrow_down: | | [net/message/message.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bmV0L21lc3NhZ2UvbWVzc2FnZS5nbw==) | `46.06% <50.00%> (+0.18%)` | :arrow_up: | | [net/message/relay\_message.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bmV0L21lc3NhZ2UvcmVsYXlfbWVzc2FnZS5nbw==) | `60.00% <50.00%> (-5.00%)` | :arrow_down: | | [protocol/xmrmaker/swap\_state.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHJvdG9jb2wveG1ybWFrZXIvc3dhcF9zdGF0ZS5nbw==) | `66.35% <58.82%> (-1.37%)` | :arrow_down: | | [ethereum/check\_swap\_creator\_contract.go](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZXRoZXJldW0vY2hlY2tfc3dhcF9jcmVhdG9yX2NvbnRyYWN0Lmdv) | `57.14% <60.00%> (-14.02%)` | :arrow_down: | | ... and [16 more](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/446?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | | ... and [5 files with indirect coverage changes](https://codecov.io/gh/AthanorLabs/atomic-swap/pull/446/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.